Skip to content

Conversation

@kingthorin
Copy link
Member

@kingthorin kingthorin commented Sep 7, 2025

Overview

Instead of simply defaulting to "Link with Sites Tree" the add-on now has a button allowing the user to control the behavior. (Default enabled to mimic existing behavior)

Update extension/panel. Add CHANGELOG entry. Update help. Add necessary support resources.

Related Issues

@psiinon
Copy link
Member

psiinon commented Sep 7, 2025

Logo
Checkmarx One – Scan Summary & Details4e886070-e2fa-41ab-a52d-04b9ce0fd903

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 31
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: z89ONTXYaYdPcNUEzfFqPVDqGfU%3D
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 35
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: ivv4LqDvobLaIQBf4po7RJO0z9E%3D
LOW Unpinned Actions Full Length Commit SHA /codeql.yml: 50
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: D2MI8bkE1KfW3jWUtbTZgCIA7fE%3D
Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Use_Of_Hardcoded_Password /addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/AuthUtils.java: 169
LOW Heap_Inspection /addOns/authhelper/src/test/java/org/zaproxy/addon/authhelper/AuthUtilsUnitTest.java: 1297
LOW Heap_Inspection /addOns/authhelper/src/test/java/org/zaproxy/addon/authhelper/AuthUtilsUnitTest.java: 1318

Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@kingthorin
Copy link
Member Author

Deconflicted

@kingthorin
Copy link
Member Author

De-conflicted

@kingthorin
Copy link
Member Author

Got most of those.

@kingthorin kingthorin force-pushed the tech-sites-link branch 2 times, most recently from 823dd3d to 91e190c Compare October 31, 2025 11:08
@kingthorin
Copy link
Member Author

Got all those.

@thc202
Copy link
Member

thc202 commented Oct 31, 2025

The stack overflow is still happening.

@kingthorin
Copy link
Member Author

Done

@thc202
Copy link
Member

thc202 commented Oct 31, 2025

@kingthorin kingthorin force-pushed the tech-sites-link branch 3 times, most recently from 2042df2 to 82e7117 Compare October 31, 2025 12:49
@kingthorin
Copy link
Member Author

The stack overflow should be fixed now. If the root node is selected or the Sites combobox only contains the default entry it doesn't try to set anything.

@thc202
Copy link
Member

thc202 commented Oct 31, 2025

It would be better to fix the issue than workaround it, if tomorrow we start persisting the findings we are back to the same problem.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Hopefully that looks better.

@thc202
Copy link
Member

thc202 commented Oct 31, 2025

Thank you!

@thc202 thc202 merged commit 021aadd into zaproxy:main Oct 31, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@kingthorin kingthorin deleted the tech-sites-link branch October 31, 2025 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants