This repository was archived by the owner on Jul 30, 2022. It is now read-only.
Support Workspace symbols #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
yorkxin commented Aug 25, 2018
server/package.json Outdated
| "coffeescript": "^2.1.0", | ||
| "vscode-languageserver": "^3.4.2" | ||
| "coffeescript-symbols": "file:../coffeescript-symbols", | ||
| "coffeescript-symbol-index": "file:../coffeescript-symbol-index", |
There was a problem hiding this comment.
Problem: these packages won't be npm install'd during npm run compile.
There was a problem hiding this comment.
Even if unit test passes, the built vsix won't run due to lack of these packages.
Publishing them to NPM could solve the problem, but that's overkill.
yorkxin force-pushed the workspace-symbols branch from 0abcfa3 to b73da6c Compare 
| High CPU load problem still exists. Last time it crashed my MBP 2017. |
yorkxin commented Aug 31, 2018
server/src/server.ts Outdated
| if (change.type === FileChangeType.Deleted) { | ||
| indexService.removeFiles([change.uri]); | ||
| } else if (change.type === FileChangeType.Changed || change.type === FileChangeType.Created) { | ||
| indexService.indexFilesInBackground([change.uri]); |
There was a problem hiding this comment.
I think this is causing fork bomb when git checkout between branches that has lots changes 💣
There was a problem hiding this comment.
Solved by deamonizing the indexer process.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Support global symbols searching
Bugs to fix in the next version
Further improvements
Checklist
client/CHANGELOG.md0.2.0