Fix CSV import/export to include tags #205
Merged
+25 −6
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
CSV export and import were not handling tags, causing tag data to be lost during backup and restore operations. This was reported in issue where users noted that tags were neither present in exports nor restored during imports.
Solution
This PR adds full tag support to both CSV export and import functionality by making minimal, surgical changes to the backup system.
Changes
Export Side:
CsvWriter.kt
to useListDeeprWithTagsAsc
instead ofDeepr
to include tag informationExportRepositoryImpl.kt
to fetch data usinglistDeeprWithTagsAsc()
queryImport Side:
ImportRepositoryImpl.kt
to parse tags from the CSV's 6th columnINSERT OR IGNORE
)Format:
"tag1, tag2, tag3"
GROUP_CONCAT(Tags.name, ', ')
format used throughout the codebaseBackward Compatibility
Old CSV files without the Tags column will continue to import successfully since:
getOrNull(5)
which safely returns null for missing columnsTesting
The implementation was verified by:
SyncRepositoryImpl.kt
Fixes the issue where tags were not included in CSV export and backup.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com
/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/agents/gradle-instrumentation-agent-8.13.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.13
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #176
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.