Fixes #93: Fixed yii\redis\ActiveRecord::deleteAll() with condition #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
samdark requested review from SilverFire, arogachev, cebe, dynasource and klimov-paul # Conflicts: # CHANGELOG.md
arogachev requested changes Mar 12, 2017
ActiveQuery.php Outdated
| if (is_array($this->where) && ( | ||
| !isset($this->where[0]) && $modelClass::isPrimaryKey(array_keys($this->where)) || | ||
| isset($this->where[0]) && $this->where[0] === 'in' && $modelClass::isPrimaryKey($this->where[1]) | ||
| isset($this->where[0]) && $this->where[0] === 'in' && $modelClass::isPrimaryKey((array)$this->where[1]) |
There was a problem hiding this comment.
You missed a space between (array) and casting value. Even within this file the other occurences of (array) are followed by space, so this is inconsistent and small code style violation.
arogachev reviewed Mar 13, 2017
| public function testDeleteAllWithCondition() | ||
| { | ||
| $deletedCount = Order::deleteAll(['in', 'id', [1, 2, 3]]); | ||
| $this->assertEquals(3, $deletedCount); |
There was a problem hiding this comment.
Maybe convert this to one liner since it fits in one line?
Member Author
There was a problem hiding this comment.
No. The variable is important for understanding the context in this case.
There was a problem hiding this comment.
@samdark Indeed, it would be not absolutely clear without it. Nevermind then.
arogachev approved these changes Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.