Fix #240: Push only release tag #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
samdark commented Jun 15, 2025
samdark commented | Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #240 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #240 by ensuring that only the release tag is pushed to GitHub instead of all tags.
- Updates the release command to call pushTag() with the release version instead of pushing all tags.
Comments suppressed due to low confidence (1)
src/App/Command/Release/MakeCommand.php:187
- Ensure that the pushTag() method is well-documented and verified to push only the intended release tag, as per the requirements of bug #240.
$git->pushTag((string) $versionToRelease); 
vjik approved these changes Jun 17, 2025
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.