Let PJAX request follows HTTP Redirect in any case #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
qiangxue added a commit that referenced this pull request Mar 20, 2014
Let PJAX request follows HTTP Redirect in any case
Member
| Since this is a fork, I'm not sure what CS we should take. Should we keep the original CS or the one used by Yii? Currently all core Yii JS are using spaces instead of tabs. |
Member
| Depends on our intention to merge changes back. If we want it code style should be kept. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As you may see in the code, I won't fire
pjax:errorevent in case of a redirect, because I think this is not useful (and a http redirect is not an error IMHO)Question, should JS files be rewritten with spaces instead of tabs ?