It makes it possible to append scripts synchronously #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sometimes it is necessary to add scripts dynamically. If you enable async option (true) scripts to load asynchronously. If false, pjax will operate as usual. Why do it? Scripts are loaded on the fly, and client scripts waiting until all the necessary scripts to connect to and then work out fine.
There was a problem hiding this comment.
Are you sure appending to head will load scripts in async mode?
Default async is true, so pjax work by default. Not quite correctly put it in the description. Fixed. |
fourteenmeister changed the title 
| Looks good to me but I think it's generic enough to go directly into pjax upstream. Worth creating a pull request against it as well. |
Already, but they rejected. defunkt#423 (comment) |
| #30 fixes the problem generally |
| Should be fixed by #30 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sometimes it is necessary to add scripts dynamically. If you enable async option (true) pjax will operate as usual. If false, scripts to load synchronously.
Why do it? Scripts are loaded on the fly, and client scripts waiting until all the necessary scripts to connect to and then work out fine.