resolve #137-luck-balance 문제풀이 및 문서추가 #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
yeonjuan reviewed Aug 14, 2019
| return (a[1] > b[1]) ? 1 : -1; | ||
| }); | ||
| | ||
| let numImportant = length - [...sorted].findIndex(x => x[1] === 1); |
Collaborator Author
There was a problem hiding this comment.
findIndex를 쓰려고 사용했습니다
yeonjuan reviewed Aug 14, 2019
| const loseImportant = [...sorted].slice(length - numImportant, length - numImportant + limit); | ||
| const winImportant = [...sorted].slice(length - numImportant + limit); | ||
| | ||
| const sumLuck = (unImportant.reduce((sum, [luck]) => sum + luck, 0) || 0) + |
Owner
There was a problem hiding this comment.
(sum, [luck]) => sum + luck반복되는 부분은 함수로 빼는것이 좋을것 같습니다.
yeonjuan reviewed Aug 14, 2019
| return (a[1] > b[1]) ? 1 : -1; | ||
| }); | ||
| | ||
| let numImportant = length - [...sorted].findIndex(x => x[1] === 1); |
Owner
There was a problem hiding this comment.
numImportant 아래의 unImportant, loseImportant, winImportant 와 이름 형식이 같은데
아랫것들은 배열이고 numImportant 는 number 로 보입니다.
배열의 경우 s 복수형을 쓰는것이 좋을것 같습니다.
yeonjuan reviewed Aug 14, 2019
| let numImportant = length - [...sorted].findIndex(x => x[1] === 1); | ||
| numImportant = (numImportant > length) ? 0 : numImportant; | ||
| | ||
| const unImportant = [...sorted].slice(0, length - numImportant); |
Owner
There was a problem hiding this comment.
length - numImportant 반복되서 사용되는 부분은 상수로 선언하는게 좋을것 같습니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.