Skip to content

Conversation

1NepuNep1
Copy link
Collaborator

@1NepuNep1 1NepuNep1 commented Sep 15, 2025

Related to (#8)

@1NepuNep1 1NepuNep1 changed the title Rewrited convert to Visitor Interface from ANTLR4 + fixed LIMIT/OFFSET Bug Rewrited convert to Visitor Interface from ANTLR4 + fixed some types casts & error texts Sep 22, 2025
@1NepuNep1 1NepuNep1 requested a review from Copilot September 22, 2025 14:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the YDB parser to use ANTLR4's Visitor interface pattern instead of a custom convert method, while also adding several utility functions for collecting different types of operators and improving type safety.

  • Replaced custom convert() method with ANTLR4's Accept() visitor pattern
  • Added type safety checks and error handling for visitor pattern conversions
  • Introduced utility functions for collecting comparison, bitwise, addition, and equality operators

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
internal/engine/ydb/utils.go Refactored extractRoleSpec to use visitor pattern and added operator collection utility functions
internal/engine/ydb/parse.go Updated statement parsing to use visitor pattern with proper type checking
go.mod Updated yql-parsers dependency version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@1NepuNep1 1NepuNep1 merged commit 1379e43 into ydb-platform:ydb Sep 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants