Skip to content

Expanding YQL Syntax support in sqlc engine #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 8, 2025
Merged

Expanding YQL Syntax support in sqlc engine #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e50d578
Added ALTER TABLE support
Sep 3, 2025
9e6ba0e
Added DO stmt support
Sep 3, 2025
b43bf8a
Fixed DO stmt generation
Sep 3, 2025
f1786d6
Refactored SELECT logic. Supported DISTINCT, HAVING, GROUP BY, ORDER …
Sep 4, 2025
7a97c79
Fixed style and types
Sep 8, 2025
b340194
Refactored DO stmt style & added some additional converts
Sep 8, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions internal/engine/ydb/catalog_tests/delete_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ func TestDelete(t *testing.T) {
},
},
OnSelectStmt: &ast.SelectStmt{
DistinctClause: &ast.List{},
ValuesLists: &ast.List{
Items: []ast.Node{
&ast.List{
Expand All @@ -110,8 +111,12 @@ func TestDelete(t *testing.T) {
},
},
},
FromClause: &ast.List{},
TargetList: &ast.List{},
FromClause: &ast.List{},
TargetList: &ast.List{},
GroupClause: &ast.List{},
WindowClause: &ast.List{},
SortClause: &ast.List{},
LockingClause: &ast.List{},
},
ReturningList: &ast.List{
Items: []ast.Node{
Expand Down Expand Up @@ -145,6 +150,7 @@ func TestDelete(t *testing.T) {
},
},
OnSelectStmt: &ast.SelectStmt{
DistinctClause: &ast.List{},
TargetList: &ast.List{
Items: []ast.Node{
&ast.ResTarget{
Expand All @@ -153,7 +159,12 @@ func TestDelete(t *testing.T) {
},
},
},
FromClause: &ast.List{},
FromClause: &ast.List{},
GroupClause: &ast.List{},
WindowClause: &ast.List{},
ValuesLists: &ast.List{},
SortClause: &ast.List{},
LockingClause: &ast.List{},
},
ReturningList: &ast.List{
Items: []ast.Node{
Expand Down
21 changes: 20 additions & 1 deletion internal/engine/ydb/catalog_tests/insert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ func TestInsert(t *testing.T) {
},
},
SelectStmt: &ast.SelectStmt{
DistinctClause: &ast.List{},
ValuesLists: &ast.List{
Items: []ast.Node{
&ast.List{
Expand All @@ -40,6 +41,10 @@ func TestInsert(t *testing.T) {
},
TargetList: &ast.List{},
FromClause: &ast.List{},
GroupClause: &ast.List{},
WindowClause: &ast.List{},
SortClause: &ast.List{},
LockingClause: &ast.List{},
},
OnConflictClause: &ast.OnConflictClause{},
ReturningList: &ast.List{
Expand Down Expand Up @@ -68,6 +73,7 @@ func TestInsert(t *testing.T) {
},
},
SelectStmt: &ast.SelectStmt{
DistinctClause: &ast.List{},
ValuesLists: &ast.List{
Items: []ast.Node{
&ast.List{
Expand All @@ -79,6 +85,10 @@ func TestInsert(t *testing.T) {
},
TargetList: &ast.List{},
FromClause: &ast.List{},
GroupClause: &ast.List{},
WindowClause: &ast.List{},
SortClause: &ast.List{},
LockingClause: &ast.List{},
},
OnConflictClause: &ast.OnConflictClause{
Action: ast.OnConflictAction_INSERT_OR_IGNORE,
Expand Down Expand Up @@ -106,7 +116,16 @@ func TestInsert(t *testing.T) {
Stmt: &ast.InsertStmt{
Relation: &ast.RangeVar{Relname: strPtr("users")},
Cols: &ast.List{Items: []ast.Node{&ast.ResTarget{Name: strPtr("id")}}},
SelectStmt: &ast.SelectStmt{ValuesLists: &ast.List{Items: []ast.Node{&ast.List{Items: []ast.Node{&ast.A_Const{Val: &ast.Integer{Ival: 4}}}}}}, TargetList: &ast.List{}, FromClause: &ast.List{}},
SelectStmt: &ast.SelectStmt{
DistinctClause: &ast.List{},
ValuesLists: &ast.List{Items: []ast.Node{&ast.List{Items: []ast.Node{&ast.A_Const{Val: &ast.Integer{Ival: 4}}}}}},
TargetList: &ast.List{},
FromClause: &ast.List{},
GroupClause: &ast.List{},
WindowClause: &ast.List{},
SortClause: &ast.List{},
LockingClause: &ast.List{},
},
OnConflictClause: &ast.OnConflictClause{Action: ast.OnConflictAction_UPSERT},
ReturningList: &ast.List{Items: []ast.Node{&ast.ResTarget{Val: &ast.ColumnRef{Fields: &ast.List{Items: []ast.Node{&ast.String{Str: "id"}}}}, Indirection: &ast.List{}}}},
},
Expand Down
Loading
Loading