feat(nm): Add support for user-defined <workspace>/node_modules symlinks #6416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dgoldstein0 reviewed Jul 29, 2024
dgoldstein0 left a comment
dgoldstein0 left a comment There was a problem hiding this comment.
thanks for the quick turnaround here! a few questions inline
packages/acceptance-tests/pkg-tests-specs/sources/node-modules.test.ts Outdated Show resolved Hide resolved
merceyz approved these changes Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes: #6415
How did you fix it?
Now the
node-moduleslinker do not try to delete or recreate<any_workspace>/node_modulesdirectories if they are symlinks and the underlying dependencies were removed or newly added.Checklist