Skip to content

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented May 2, 2024

What's the problem this PR addresses?

#6133 (cc @clemyan) enabled noEmit by default which caused yarn pack to not get any build output.

Fixes #6265

How did you fix it?

Explicitly set noEmit: false in the build script.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.
arcanis
arcanis previously approved these changes May 2, 2024
@merceyz merceyz force-pushed the merceyz/build/fix-builds branch from e53dde2 to 0db762b Compare May 2, 2024 17:26
@merceyz merceyz changed the title build: enable TypeScript emit build: explicitly set noEmit: false in the build script May 2, 2024
@arcanis arcanis merged commit 33a8c80 into master May 2, 2024
@arcanis arcanis deleted the merceyz/build/fix-builds branch May 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants