Skip to content

Fix parser stringify subshell brackets #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2024
Merged

Fix parser stringify subshell brackets #6254

merged 2 commits into from
May 1, 2024

Conversation

@clemyan
Copy link
Member

@clemyan clemyan commented Apr 29, 2024

What's the problem this PR addresses?

With @yarnpkg/parsers, stringifying a subshell (e.g. echo $(echo a)) uses the wrong brackets (e.g. echo ${echo a})

How did you fix it?

Change to use the correct brackets.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.
@clemyan clemyan changed the title Parser stringify subshell brackets Fix parser stringify subshell brackets Apr 29, 2024
@arcanis arcanis merged commit 8d8b318 into yarnpkg:master May 1, 2024
@clemyan clemyan deleted the parser-stringify-subshell-brackets branch July 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@clemyan @arcanis