Skip to content

Conversation

@arcanis
Copy link
Member

@arcanis arcanis commented Jan 29, 2024

What's the problem this PR addresses?

For some reason we can't run yarn prepack in @yarnpkg/libzip. I'm not sure why, but upgrading to TS 5.3.3 fixes the issue. It's also a good opportunity to avoid relying on a RC release.

How did you fix it?

Upgrades TypeScript. It doesn't reveal any new issue in our types.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.
@merceyz
Copy link
Member

merceyz commented Jan 29, 2024

Was probably fixed by microsoft/TypeScript#56421.

@arcanis arcanis merged commit 124e562 into master Jan 29, 2024
@arcanis arcanis deleted the mael/ts-upgrade branch January 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants