Skip to content

Conversation

@andreyfel
Copy link

testem specifies mustache@^3.0.0 and consolidate@0.15.1 in its dependencies.
When you install testem using pnpm@7.1.0 it ends up with versions conflict:

. └─┬ ember-cli └─┬ testem └─┬ consolidate └── ✕ unmet peer mustache@^4.0.1: found 3.2.1 

What's the problem this PR addresses?

...

How did you fix it?

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the range declared upstream, in order to change it here it needs to be changed upstream as well.
https://github.com/tj/consolidate.js/blob/ec2e1ae511d37a69716022311a4ca29785f62143/package.json#L121

@merceyz merceyz changed the title Allow mustache@^3.0.0 to avoid conflicts fix(extensions): allow consolidate to use mustache@^3.0.0 May 17, 2022
@andreyfel
Copy link
Author

andreyfel commented May 17, 2022

@merceyz the problem is that mustache@3 must be used with consolidate@0.15.1 and mustache@4 must be used with consolidate@^0.16.0 according to this. What is the best way to achieve that? Have a separate entry for consolidate<=0.15.1 and another one for consolidate>0.15.1?

@andreyfel
Copy link
Author

Closing in favor of #4467

@merceyz
Copy link
Member

merceyz commented May 17, 2022

There is no need to close this PR and open a new one, update this PR instead.

@merceyz
Copy link
Member

merceyz commented May 17, 2022

the problem is that mustache@3 must be used with consolidate@0.15.1 and mustache@4 must be used with consolidate@^0.16.0 according to this

Alright, in that case the need for an upstream PR is void 👍

What is the best way to achieve that? Have a separate entry for consolidate<=0.15.1

Yes, add an entry before the current one that only targets consolidate@<0.16.0 and only specifies the mustache@3 peer dependency.

testem specifies mustache@^3.0.0 and consolidate@0.15.1 in its dependencies. When you install testem using pnpm@7.1.0 it ends up with versions conflict: ``` . └─┬ ember-cli └─┬ testem └─┬ consolidate └── ✕ unmet peer mustache@^4.0.1: found 3.2.1 ```
@andreyfel
Copy link
Author

@merceyz please check if I did it correctly.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merceyz merceyz changed the title fix(extensions): allow consolidate to use mustache@^3.0.0 fix(extensions): allow consolidate@<0.16.0 to use mustache@^3.0.0 May 18, 2022
@merceyz merceyz enabled auto-merge (squash) May 18, 2022 15:40
@merceyz merceyz merged commit 18f26e9 into yarnpkg:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants