Skip to content

Conversation

@knishiura-lab
Copy link

It intended that user can walk through available widgets (middle column in screenshot) by pressing up and down key. Thus, when user hit those keys, selection shoudn't be submit. There was bug in this condition check, and tshis PR fix it.

Tested on Firefox on Ubuntu. On Chrome, both new and old code works for whatever reason.

available-widget

@westonruter
Copy link
Contributor

@knishiura-lab Good catch! I merged into the develop branch and this will be included in the next release.

What's your WordPress.org profile/username?

@knishiura-lab
Copy link
Author

My username is daisy1754
Thanks!

@westonruter
Copy link
Contributor

@knishiura-lab I can't seem to find a profile at http://profiles.wordpress.org/daisy1754/

@knishiura-lab
Copy link
Author

@westonruter
Hmm, I misunderstood what is wordpress account.
I have gravatar account and it's my profile (http://en.gravatar.com/daisy1754 ). I may have made wordpress account as well when taking gravatar account, but not sure. I'm just trying wordpress locally and don't have my own blog hosted by wordpress. Hope it answers your question :)

@westonruter
Copy link
Contributor

@knishiura-lab ok, you want me to link to your Gravatar profile in the changelog?

@knishiura-lab
Copy link
Author

@westonruter
Wow, that would be cool!
Is it possible to put my github url https://github.com/knishiura-lab instead?

@westonruter
Copy link
Contributor

Happily! Thanks again for your contribution. 🙇

@knishiura-lab
Copy link
Author

cool, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants