Show linkages between widget controls and widgets in preview #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| I'm working on solving this issue. |
Adds effects to editing widgets, border effect on control hover, and scrolls to widget on input click.
Conflicts: widget-customizer.css widget-customizer.js
…omizer Conflicts: widget-customizer-preview.js widget-customizer.js
… control on widget preview click
…omizer into rfvcorreia-master
Add some phpDoc blocks, do some cleanup
Eliminate overloaded and abused wp_localized_script so we can export non-string data (registered sidebar objects)
Use new getControlInstanceForWidget API to find control instance for given widget rendered in sidebar
Contributor Author
| @rfvcorreia added a bunch of commits, worked out an API ( |
Widget flashes a highlight when hovering, clicking, or updating a widget. Move highlight and scrolling into methods. Add helper methods for getting getting elements.
westonruter added a commit that referenced this pull request Sep 23, 2013
Highlight and scroll widget into view in preview window
Contributor Author
| Note that this issue resolves a major usability problem illustrated by the user test video via @shaunandrews. Clicking a widget in the preview will now will open up the widget form control in the customizer panel. |
fnakstad added a commit to knishiura-lab/wp-widget-customizer that referenced this pull request Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When beginning to edit a widget or when hitting Update, the preview window should scroll the widget into view, or make sure it is in view. Likewise, when hovering over a widget control, the widget in the preview window should highlight with a red outline, and likewise when clicking on a widget in the preview, the corresponding widget control should expand in the customizer panel.
This issue resolves a major usability problem illustrated by the user test video via @shaunandrews. Clicking a widget in the preview will now will open up the widget form control in the customizer panel.