Add shift by multiple constant #1220
Draft
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@serge-sans-paille @JohanMabille this ideas works, but I cannot figure out how to refactor
bitwise_lshift_as_twice_largerinto a separate header.The issue:
xsimd_sse2.hppneedsutils/shits.hppforbitwise_lshift_as_twice_largerbitwise_lshift_as_twice_largerneeds definitions fromxsimd_sse2.hpp.avx2Forward declaring all the needed functions overloads from
sse2andavx2and the arch types inutils/shits.hpp.Perhaps it should use the functions from
xsimd_apiinstead? (which would also be better if there is a better implementation further down in the inheritance tree).Close #1218