Overwrite encoding property in _DuplicateWriter #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`_DuplicateWriter` wraps `sys.stdout` and applications might expect the encoding being set to a "real" value to determine the encoding to use. However `_DuplicateWriter` never sets it so the property defaults to `None`. As that class is basically a wrapper around its `first` stream it should forward the encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
_DuplicateWriterwrapssys.stdoutand applications might expect the encoding being set to a "real" value to determine the encoding to use.However
_DuplicateWriternever sets it so the property defaults toNone. As that class is basically a wrapper around itsfirststream it should forward the encoding