bugfix: fix layernorm & rmsnorm f16 overflow #335
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduction
Thanks for sharing this awesome code. Recently, I find float16 will overflow in
layer_norm
andrms_norm
and get zero after dividing infinity. That's why regular rms-norm impl will cast inputs to float32 and truncate to f16 after norm, e.g. Qwen3RMSNorm. Results are shown as below.Plus,
LANUCH_RMS_NORM_F16x8F32_KERNEL
accidently calledrms_norm_f16x8_f16_kernel
, which causes f32 kernel overflows, too. So I change the name back.Contents
rmsnorm_f16x8_f32
. It wasrmsnorm_f16x8_f16
before fix.logs
GPU: RTX 3060Ti Laptop