Output repo #216
Merged
Output repo #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fix for AEMaaCS live output functionality by replacing file-based output storage with repository-based storage. The changes address cluster-related issues where file outputs weren't consistently accessible across cluster nodes.
- Replaces file-based code output storage with repository-based storage using JCR
- Adds quiet logging functionality to repository operations
- Refactors user impersonation logic to work better with AEMaaCS cluster environments
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui.frontend/src/utils/spectrum.ts | Extracts magic number 0.8 into a named constant for better maintainability |
| core/src/main/java/dev/vml/es/acm/core/util/ResolverUtils.java | Improves user impersonation handling and adds Optional import for better null handling |
| core/src/main/java/dev/vml/es/acm/core/repo/RepoResource.java | Removes direct logger usage in favor of repo-based logging for consistency |
| core/src/main/java/dev/vml/es/acm/core/repo/Repo.java | Adds quiet logging functionality and NOPLogger support for silent operations |
| core/src/main/java/dev/vml/es/acm/core/code/QueuedExecution.java | Updates to use new CodeOutput interface instead of file-based output |
| core/src/main/java/dev/vml/es/acm/core/code/ExecutionQueue.java | Integrates new repository-based output system with execution queue |
| core/src/main/java/dev/vml/es/acm/core/code/ExecutionContext.java | Updates execution context to use repository-based output for run mode |
| core/src/main/java/dev/vml/es/acm/core/code/CodeOutputRepo.java | New implementation of repository-based code output storage with async saving |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| | ||
| public static String serviceOrImpersonatedUserId(ResourceResolver resourceResolver) { | ||
| return resourceResolver.getUserID(); // assumes preference: impersonated ID, service user ID | ||
| public static String serviceOrImpersonatedUserId(ResourceResolver resolver) { |
There was a problem hiding this comment.
wrong "user" may start appearing in history entries; but to be confirmed
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AEMaaCS live output fix ; due to cluster issue