Script scheduler cluster fix #210
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a script scheduler cluster fix by refactoring UI component layouts and simplifying backend deployment logic. The main focus is on reorganizing button groups for better visual consistency and removing unnecessary deployment-time threading mechanisms in the Java backend.
- Reorganized button layout in UI components for better visual grouping
- Changed button text from "Sync" to "Synchronize" for clarity
- Simplified Java scheduler by removing deployment-specific threading logic
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ScriptsSyncButton.tsx | Updated button text from "Sync" to "Synchronize" |
| ScriptAutomaticList.tsx | Moved Configure and Boot buttons to right-aligned ButtonGroup |
| ExecutorResetButton.tsx | Changed button style from "fill" to "outline" |
| ExecutorBootButton.tsx | Changed button style from "fill" to "outline" |
| CodeExecutor.tsx | Reorganized button layout with status light in center |
| ScriptScheduler.java | Removed deployment executor and added cluster-aware deactivation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (deployJobExecutor != null) { | ||
| deployJobExecutor.shutdownNow(); | ||
| deployJobExecutor = null; | ||
| if (!instanceInfo.isCluster()) { |
There was a problem hiding this comment.
when some cluster node is up the old one becomes deactivated; as sling schedules are global (stored in 1 repo) the just scheduled scripts become quickly unscheduled by that just-killed node.
so that simple fix should do the trick; only when all nodes are shutdown there is nothing shutting down the scheduler globally but... whenever any new node become available it always cleans all previous schedules by doing unscheduleBoot() and unscheduleScripts() so we will finally land in eventually-consistent state
1 participant
No description provided.