Skip to content

Conversation

krystian-panek-vmltech
Copy link
Collaborator

@krystian-panek-vmltech krystian-panek-vmltech commented Sep 19, 2025

on AEMaaCS Sling Scheduler does not work initially / during deployment so we need to postpone boot job schedule (like in AECU - https://github.com/valtech/aem-easy-content-upgrade/blob/develop/cloud.startup.hook/src/main/java/de/valtech/aecu/startuphook/AecuCloudStartupService.java )

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds an asynchronous "deployment wait" phase so automatic scripts are only booted after the instance becomes healthy, introducing a new deployment-specific health check retry configuration and adjusting existing boot retry defaults. Also updates the vendor package installation target path in the test setup script.

  • Added deployJob with asynchronous execution to defer boot until instance health is confirmed
  • Introduced healthCheckRetryCountDeployment config and reduced boot retry default from 90 to 60
  • Changed vendor package install target path from container/install to application/install

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
test/project/setup.sh Adjusts vendor package installation target path.
core/src/main/java/dev/vml/es/acm/core/script/ScriptScheduler.java Adds deployment wait logic, new config property, modifies boot retry defaults, formatting changes.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@krystian-panek-vmltech krystian-panek-vmltech merged commit 5541155 into main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant