Use the %run hook function for running binaries. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…&run primitive, if %run is unset).
Collaborator Author
| Well, I was coming back to switch this to the more-consistent behavior (throw an error if EDIT: Actually, I was wrong, I think this might have been one of the recent exception-related bug fixes that haven't been merged into my development branch. It works at head. |
Collaborator Author
| @wryun, any opinion on this? It's not even approximately a bug fix so I don't feel confident merging it unilaterally. |
jpco added a commit to jpco/es-shell that referenced this pull request Mar 10, 2025
This PR combines: - PR wryun#149, "Add a few things to make $&waiting more flexible." - PR wryun#90, "Use the %run hook function for running binaries." - A heap of new logic in proc.c and prim-sys.c, generally much cleaner than in the original newjobcontrol branch - Support for '+signame' signal handling to sig_ignore in the shell pgrp - A draft share/job-control.es script Overall things seem pretty solid. It even builds and runs successfully right now with `-ansi -D_POSIX_C_SOURCE=200112L -pedantic -DGCDEBUG=1`, which is a pleasant surprise. It still needs: - A lot of testing - Some more refactoring of pgroup handling, especially around exit statuses - Follow-up on WCONTINUED and WIFCONTINUED alternatives in POSIX.1-2001 (or whether ifdef'ing is worth it) - A way to hook the %interactive-loop to add signal handlers and run newpgrp on startup (this is a blocker to running job-control.es from .esrc right now)
jpco added a commit to jpco/es-shell that referenced this pull request Mar 10, 2025
This PR combines: - PR wryun#149, "Add a few things to make $&waiting more flexible." - PR wryun#90, "Use the %run hook function for running binaries." - A heap of new logic in proc.c and prim-sys.c, generally much cleaner than in the original newjobcontrol branch - Support for '+signame' signal handling to sig_ignore in the shell pgrp - A draft share/job-control.es script Overall things seem pretty solid. It even builds and runs successfully right now with `-ansi -D_POSIX_C_SOURCE=200112L -pedantic -DGCDEBUG=1`, which is a pleasant surprise. It still needs: - A lot of testing - Some more refactoring of pgroup handling, especially around exit statuses - Follow-up on WCONTINUED and WIFCONTINUED alternatives in POSIX.1-2001 (or whether ifdef'ing is worth it) - A way to hook the %interactive-loop to add signal handlers and run newpgrp on startup (this is a blocker to running job-control.es from .esrc right now)
jpco added a commit to jpco/es-shell that referenced this pull request Mar 10, 2025
This PR combines: - PR wryun#149, "Add a few things to make $&waiting more flexible." - PR wryun#90, "Use the %run hook function for running binaries." - A heap of new logic in proc.c and prim-sys.c, generally much cleaner than in the original newjobcontrol branch - Support for '+signame' signal handling to sig_ignore in the shell pgrp - A draft share/job-control.es script Overall things seem pretty solid. It even builds and runs successfully right now with `-ansi -D_POSIX_C_SOURCE=200112L -pedantic -DGCDEBUG=1`, which is a pleasant surprise. It still needs: - A lot of testing - Some more refactoring of pgroup handling, especially around exit statuses - Follow-up on WCONTINUED and WIFCONTINUED alternatives in POSIX.1-2001 (or whether ifdef'ing is worth it) - A way to hook the %interactive-loop to add signal handlers and run newpgrp on startup (this is a blocker to running job-control.es from .esrc right now)
jpco force-pushed the master branch 3 times, most recently from 64361a8 to a23a7a0 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #80.
I'm actually not sure if it's better to go with this "use the primitive if
%runis unset" fallback, or to just throw an error if%runhappens to be unset. The former is more useful but the latter is more consistent.