Skip to content

Conversation

@kidunot89
Copy link
Collaborator

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Fixes bug and improves error handling in Session_Transaction_Manager::pop_transaction_id

Thanks to @Shazamepool for identifying the bug and diversing the solution.

Does this close any currently open issues?

Resolves #844

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:
@kidunot89 kidunot89 added the bugfix Implements bugfix label May 8, 2024
@kidunot89 kidunot89 self-assigned this May 8, 2024
@kidunot89 kidunot89 force-pushed the fix/transaction-manager-pop-fix branch from bb5891e to 3aa56f4 Compare May 17, 2024 04:13
@kidunot89 kidunot89 merged commit 2543f33 into wp-graphql:develop May 21, 2024
@kidunot89 kidunot89 deleted the fix/transaction-manager-pop-fix branch May 21, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Implements bugfix

1 participant