Skip to content

Conversation

@kidunot89
Copy link
Collaborator

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Adds the value "NAME" to the "PostTypeOrderbyEnum" enumeration type. It's tied the post_title field of products.

Does this close any currently open issues?

Fixes #588

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:
@kidunot89 kidunot89 added the enhancement New feature or request label Mar 29, 2023
@kidunot89 kidunot89 self-assigned this Mar 29, 2023
@kidunot89 kidunot89 requested review from jasonbahl and removed request for jasonbahl March 29, 2023 16:48
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c39aa87 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.0% (0.0% change).

View more on Code Climate.

@kidunot89 kidunot89 merged commit 461caad into wp-graphql:develop Mar 29, 2023
@kidunot89 kidunot89 added bugfix Implements bugfix and removed bugfix Implements bugfix labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

1 participant