Fix wrong function args in sale price and remove wc_get_price_to_display from raw price. #716
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…_price_to_display from raw price.
creative-andrew changed the title ![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }, | ||
| 'priceRaw' => function() { | ||
| return ! empty( $this->wc_data->get_price() ) ? \wc_get_price_to_display( $this->wc_data ) : null; | ||
| return ! empty( $this->wc_data->get_price() ) ? $this->wc_data->get_price() : null; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| Code Climate has analyzed commit 494df13 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.0% (0.0% change). View more on Code Climate. |
kidunot89 approved these changes Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
In this commit , the arguments passed into the function
\wc_get_price_to_displayare incorrect.The function receives as a parameter the
$productand an array$args.We are currently including the
$productinside the$argsarray.https://woocommerce.github.io/code-reference/namespaces/default.html#function_wc_get_price_to_display
Additionally, this PR removes
\wc_get_price_to_displayfrom thepriceRawto be consistent with the other raw prices.Raw price should not be passed into functions such as
\wc_get_price_to_displayor\wc_graphql_price