Skip to content

Adds noop for set_customer_session_cookie. #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kidunot89 merged 2 commits into from
Mar 10, 2023
Merged

Adds noop for set_customer_session_cookie. #710

kidunot89 merged 2 commits into from
Mar 10, 2023

Conversation

@creative-andrew
Copy link
Contributor

@creative-andrew creative-andrew commented Feb 27, 2023 •
edited by kidunot89
Loading

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Overwrites set_customer_session_cookie with a noop in the QL_Session_Handler

Does this close any currently open issues?

#709
@creative-andrew creative-andrew changed the title Added noop for set_customer_session_cookie. Adds noop for set_customer_session_cookie. Feb 27, 2023
@kidunot89 kidunot89 self-requested a review March 10, 2023 16:12
kidunot89
kidunot89 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good patch, Bro 👍🏿
@creative-andrew creative-andrew force-pushed the fix/set-cookie-session-handler branch from ac6551f to cba1928 Compare March 10, 2023 18:52
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Mar 10, 2023

Code Climate has analyzed commit a48791e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.0% (0.0% change).

View more on Code Climate.
@kidunot89 kidunot89 merged commit 2b93c07 into wp-graphql:develop Mar 10, 2023
@kidunot89 kidunot89 added the bugfix Implements bugfix label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Implements bugfix

2 participants

@creative-andrew @kidunot89