Add filter to add custom fields to product sort #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| Code Climate has analyzed commit 4f3a928 and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 94.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.9% (7.7% change). View more on Code Climate. |
Contributor
| I believe this is related: |
kidunot89 approved these changes Jan 23, 2023
Collaborator
kidunot89 left a comment
kidunot89 left a comment There was a problem hiding this comment.
Looks good to me, thanks for the hard work 👍🏿
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR implements a 'graphql_woocommerce_products_add_sort_fields' hook to add custom sort fields to products. Currently it is possible to add values using the 'Products_orderby_enum_values' hook, but because of the hardcoded switch that the current master branch has, all the custom added values are ignored.
Does this close any currently open issues?
#694
Where has this been tested?