Skip to content

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Sep 12, 2023

Fixes #21261

To test:

  1. On web, create a new post with the Classic Editor
  2. Insert two images from the web editor (I used the first two from the iPhone Simulator library)
  3. Publish the post or save as draft
  4. Open the post in the Classic Editor (Aztec) in the app running iOS 17
  5. Place the cursor after the second image and press backspace until all content is erased

Repeat the test with iOS 16.

Regression Notes

  1. Potential unintended areas of impact

    • Classic Editor
    • Block Editor (since it relies on Aztec)
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@twstokes twstokes self-assigned this Sep 12, 2023
@twstokes twstokes changed the title [Do not merge] Test Aztec iOS 17 crash fix Upgrade Aztec to include iOS 17 crash fix Sep 12, 2023
@twstokes twstokes added this to the 23.3 milestone Sep 12, 2023
@twstokes twstokes marked this pull request as ready for review September 12, 2023 18:37
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21554-c30fbb7
Version23.2
Bundle IDorg.wordpress.alpha
Commitc30fbb7
App Center BuildWPiOS - One-Offs #7046
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
@twstokes twstokes modified the milestones: 23.3, 23.2 ❄️ Sep 12, 2023
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21554-c30fbb7
Version23.2
Bundle IDcom.jetpack.alpha
Commitc30fbb7
App Center Buildjetpack-installable-builds #6090
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
@peril-wordpress-mobile
Copy link

Fails
🚫 Podfile: reference to a commit hash for WordPress-Aztec-iOS,WordPress-Editor-iOS
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've tested this using the classic editor and it works as expected for both iOS 17, 16, and 15. 🚀

@fluiddot
Copy link
Contributor

Heads up that I'm cherry-picking this fix to incorporate as a beta fix in 23.2: #21574

@twstokes twstokes closed this Sep 14, 2023
@twstokes twstokes deleted the fix/aztec-ios17-crash branch September 14, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants