Skip to content

Fix Carthage build for Xcode 12 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2021
Merged

Fix Carthage build for Xcode 12 #1317

merged 4 commits into from
Jan 4, 2021

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Dec 30, 2020

Fixes #1313

Adds a Carthage script and configures a setting in the project to allow to build Gridicons on the Example project.

To test:

  • Make sure you are able to build and run the Example project following the updated instructions in the readme.
@SergioEstevao SergioEstevao added this to the Next Stable milestone Dec 30, 2020
guarani
guarani approved these changes Dec 30, 2020
View reviewed changes
Copy link

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SergioEstevao!

Maybe we could link back to the original solution here: Carthage/Carthage#3019 (comment), wdyt?
@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Jan 1, 2021

LGTM! Thanks @SergioEstevao!

Maybe we could link back to the original solution here: Carthage/Carthage#3019 (comment), wdyt?

Do you think we should add the link in the Readme file of this repo, in the part I suggest the alternative use for Xcode 12?
@guarani
Copy link

guarani commented Jan 4, 2021

Do you think we should add the link in the Readme file of this repo, in the part I suggest the alternative use for Xcode 12?

@SergioEstevao what do you think if we add a comment in Example/carthage.sh that links back to Carthage/Carthage#3019 (comment)?
@SergioEstevao SergioEstevao merged commit bec35ea into develop Jan 4, 2021
@SergioEstevao SergioEstevao deleted the issue/1313_carthage_build branch January 4, 2021 18:13
@dcalhoun
Copy link
Member

dcalhoun commented Feb 22, 2021

Moving this PR to the existing 1.19.4 milestone. There appears to have been some confusion and two milestones were created — 1.19.4 and a "Next Stable." The latter will become the milestone for a future release.

Let me know if I am mistaken and we should revert the milestone change. Thanks!
@dcalhoun dcalhoun modified the milestones: Next Stable, 1.19.4 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Tech Debt / Tech Task

4 participants

@SergioEstevao @guarani @dcalhoun