Register callbacks with highest priority #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Could we pick some arbitrarily high value but not something that people can't override (basically not PHP_INT_MAX). I fear that in the future there'll be some usecase where someone wants to register before the merge-plugin but if we make this the max possible, then that won't be possible at all. |
Member Author
| Yeah, that's reasonable. My big hammer solution here is pretty big. |
Attempt to take action before other Composer plugins that may be in use by registering our callbacks using a very high priority (50,000) rather than the default priority of 0. Closes wikimedia#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Attempt to take action before other Composer plugins that may be in use
by registering our callbacks using the highest possible priority.
Closes #99