Editorial: use leading and trailing surrogate #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ricea reviewed Apr 5, 2023
Collaborator
ricea left a comment
ricea left a comment There was a problem hiding this comment.
Only the title says "pending surrogate"; should that be "trailing surrogate" instead?
annevk force-pushed the annevk/leading-trailing branch from 8907c46 to 8305d1e Compare annevk changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also introduce an operation to obtain a scalar value from surrogates.
Eventually the lead/trail byte stuff needs to be made consistent with this as well.
Preview | Diff