New functionality to search for specific email and to delete and email #19
Conversation
| } | ||
| $this->cleanInbox(); | ||
| } | ||
| */ |
There was a problem hiding this comment.
Agreed with @sergeyklay, the cleanup functionality is useful when running test in some cases, you can always deactivate it from the config.
| $attachments = $this->fetchAttachmentsOfLastMessage(); | ||
| | ||
| $this->assertEquals($bool, count($attachments) > 0); | ||
| } |
There was a problem hiding this comment.
Agreed with @sergeyklay, no need to delete method because they seem related to the feature you are trying to add.
| } | ||
| $this->cleanInbox(); | ||
| } | ||
| */ |
There was a problem hiding this comment.
Agreed with @sergeyklay, the cleanup functionality is useful when running test in some cases, you can always deactivate it from the config.
| $testEmailAddress = $this->config['testEmailAddress']; | ||
| | ||
| return $testEmailAddress; | ||
| } |
There was a problem hiding this comment.
Providing a default in the config would be preferred. Also, the use of a temporary variable is not necessary here and could be avoided:
public function getTestEmailAddress() { return $this->config['testEmailAddress']; } | $messages = json_decode($messages, true); | ||
| } while ($counter < 60 && $messages == Null); | ||
| } | ||
| return array_shift($messages); |
There was a problem hiding this comment.
The method searchForMessage() could be added in addition with the fetchLastMessage method, no need to get rid of it.
There was a problem hiding this comment.
Also:
- the
elsestatement could be avoided - the InboxID parameter should be optional, since it will default to the one in the config
- emails are usually received by mailtrap pretty fast, not sure doing 60 attempts is necessary
- the use of
sleep()andechois not recommended, nor necessary.
| } | ||
| return array_shift($messages); | ||
| } | ||
| |
There was a problem hiding this comment.
- The else statement could be avoided here as well
- The
$inboxIDshould be the second parameter and optional as it will default to the config.
| $messages = $this->client->delete("inboxes/{$this->config['inbox_id']}/messages/".$messageID); | ||
| } | ||
| } | ||
| |
There was a problem hiding this comment.
- Make $inboxID optional
- Else statement unnecessary.
| $attachments = $this->fetchAttachmentsOfLastMessage(); | ||
| | ||
| $this->assertEquals($bool, count($attachments) > 0); | ||
| } |
There was a problem hiding this comment.
Agreed with @sergeyklay, no need to delete method because they seem related to the feature you are trying to add.
3 participants
No description provided.