Skip to content

fix: allow both http and https for server URL, default to https if mi… #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: allow both http and https for server URL, default to https if mi… #871

wants to merge 1 commit into from

Conversation

kiingxo
Copy link

@kiingxo kiingxo commented Jul 17, 2025

Proposed Changes

  • Allow both http and https protocols for the server URL.
  • If the user does not specify a protocol, default to https://.
  • Prevents connection issues for users with self-hosted HTTP servers or strict HTTPS-only servers.

Related Issue(s)

Closes #860

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR (run dart format .)
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.
@rolandgeider
Copy link
Member

hey @kiingxo thanks for the PR!

We would need to use the normalizeServerUrl helper to lib/widgets/auth/server_field.dart since currently the validation would not work

Simulator Screenshot - iPhone 16 Plus - 2025-08-25 at 19 52 58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kiingxo @rolandgeider