Skip to content

Conversation

@henryqdineen
Copy link
Contributor

When client.overlay is set to false the resource query string will be contain overlay=false (relevant code). This PR fixes the enabledFeatures logic to handle cases when overlay=false

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Fixes misleading console logs

Breaking Changes

No

Additional Info

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (af6bd68) to head (ca13b9e).
Report is 124 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #5464 +/- ## ========================================== - Coverage 90.29% 83.38% -6.92%  ========================================== Files 15 13 -2 Lines 1577 2028 +451 Branches 601 745 +144 ========================================== + Hits 1424 1691 +267  - Misses 140 303 +163  - Partials 13 34 +21 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@alexander-akait
Copy link
Member

@henryqdineen Can we fix linting?

@ovflowd
Copy link
Member

ovflowd commented Apr 29, 2025

@alexander-akait, it seems like a GHSA was released. Can we open a PR with npm audit --fix, seems like 2.0.9 is patched and we're on 2.0.7

@alexander-akait
Copy link
Member

@ovflowd oh, I see, I will resolve it before the next release, so let's merge it

@alexander-akait alexander-akait merged commit 18e72ee into webpack:master Apr 29, 2025
40 of 53 checks passed
@snitin315 snitin315 mentioned this pull request Apr 30, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants