Skip to content

Conversation

@snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes.

Motivation / Use-Case

Resolve TODO.

  • Check if 'serveIndex' property is defined in 'optionsForStatic'
  • If 'serveIndex' is a boolean and true, use default 'serveIndex'
  • If 'serveIndex' is an object, merge its properties with default 'serveIndex'
  • If 'serveIndex' is neither a boolean true nor an object, use it as-is

Breaking Changes

Yes, updated defaults.

Additional Info

No.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (a87dc53) 92.04% compared to head (551e612) 92.05%.

Additional details and impacted files
@@ Coverage Diff @@ ## next #4968 +/- ## ========================================== + Coverage 92.04% 92.05% +0.01%  ========================================== Files 15 15 Lines 1571 1573 +2 Branches 595 597 +2 ========================================== + Hits 1446 1448 +2  Misses 116 116 Partials 9 9 
Files Changed Coverage Δ
lib/Server.js 94.26% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snitin315 snitin315 merged commit 1750353 into next Aug 19, 2023
@snitin315 snitin315 deleted the refactor/merge-serveIndex-defaults branch August 19, 2023 01:12
snitin315 added a commit that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants