fix: replace :: with localhost before openBrowser() #4856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chousheng requested review from alexander-akait, hiroppy, snitin315 and anshumanv as code owners 
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #4856 +/- ## ========================================== + Coverage 91.72% 91.85% +0.12% ========================================== Files 16 16 Lines 1704 1706 +2 Branches 647 649 +2 ========================================== + Hits 1563 1567 +4 + Misses 130 128 -2 Partials 11 11
☔ View full report in Codecov by Sentry. |
chousheng force-pushed the fix-ipv6-unspecified-addr-open-browser branch from ac971bd to 436bbd4 Compare 
snitin315 reviewed May 10, 2023
alexander-akait approved these changes May 11, 2023
| @alexander-akait, @snitin315. Thank you for reviewing! Please let me know if I need to rebase the commit or do anything else before getting the PR merged. |
snitin315 approved these changes May 11, 2023
| We will merge this once CI is green. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
test/server/open-option.test.js is modified.
Motivation / Use-Case
This PR resolves #4855. See #4855 for more details.
Breaking Changes
N/A
Additional Info
Below are the screencasts showing the fix on Windows and GitHub Codespaces.
Windows:
windows-before-fix.mov
windows-after-fix.mov
GitHub Codespaces:
codespaces-before-fix.mov
codespaces-after-fix.mov