Skip to content

chore: run tests on node 17.x in CI #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 9, 2021
Merged

chore: run tests on node 17.x in CI #3965

merged 9 commits into from
Nov 9, 2021

Conversation

@anshumanv
Copy link
Member

@anshumanv anshumanv commented Oct 21, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

NA

Motivation / Use-Case

Node 17 is out so testing running dev-server tests in CI

Breaking Changes

Shouldn't

Additional Info
@anshumanv
Copy link
Member Author

anshumanv commented Oct 21, 2021

need some tweaks webpack/webpack#14532 will update tomorrow
@codecov
Copy link

codecov bot commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #3965 (51b59f9) into master (270da15) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #3965 +/- ## ======================================= Coverage 92.62% 92.62% ======================================= Files 14 14 Lines 1410 1410 Branches 519 519 ======================================= Hits 1306 1306 Misses 96 96 Partials 8 8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270da15...51b59f9. Read the comment docs.
rishabh3112
rishabh3112 reviewed Oct 22, 2021
View reviewed changes
Copy link
Member

@rishabh3112 rishabh3112 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a TODO here so as to remove workaround once resolved on webpack core.

EDIT:
Looks like node v17 and webpack 4 tests are stuck on ubuntu and macos.
@anshumanv
Copy link
Member Author

anshumanv commented Oct 22, 2021

Not sure why they're stuck maybe we need to skip node 17, webpack 4 combination 🤔
@rishabh3112
Copy link
Member

rishabh3112 commented Oct 22, 2021 •
edited
Loading

Not sure why they're stuck

Same hashing algorithm issue 😞, check logs.
@alexander-akait
Copy link
Member

alexander-akait commented Oct 26, 2021

webpack v4 should not be run on node v17
@anshumanv
Copy link
Member Author

anshumanv commented Oct 26, 2021

Yep let's skip the combination
@anshumanv
Copy link
Member Author

anshumanv commented Oct 26, 2021

Seems like node 17 is stuck again 😞
alexander-akait
alexander-akait reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it to separate file helper file and name hashFunction: getHashFunction()
@anshumanv
Copy link
Member Author

anshumanv commented Oct 26, 2021

Got it
@alexander-akait alexander-akait merged commit 04a144f into master Nov 9, 2021
@alexander-akait alexander-akait deleted the ci-17 branch November 9, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@anshumanv @rishabh3112 @alexander-akait