chore: use default node cache for deps #3566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
anshumanv requested review from alexander-akait, hiroppy, knagaitsev and snitin315 as code owners 
| key: ${{ runner.os }}-${{ matrix.webpack-version }}-node-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-${{ matrix.webpack-version }}-node- | ||
Member
There was a problem hiding this comment.
We need webpack-version here, otherwise cache was wrong
Member Author
There was a problem hiding this comment.
if I understand correctly, we probably won't need it because we do an install after deps are restored so it'll do a fresh install for webpack version
Codecov Report
@@ Coverage Diff @@ ## master #3566 +/- ## ======================================= Coverage 94.27% 94.27% ======================================= Files 15 15 Lines 1274 1274 Branches 440 440 ======================================= Hits 1201 1201 Misses 67 67 Partials 6 6 Continue to review full report at Codecov.
|
snitin315 reviewed Jul 24, 2021
Member Author
| it is single job, no need cache there |
snitin315 previously approved these changes Jul 24, 2021
alexander-akait force-pushed the ci-cache branch from 7dd364d to 0d0aeca Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yet to
Motivation / Use-Case
use inbuilt node cache
Breaking Changes
no
Additional Info
https://github.com/actions/setup-node#caching-packages-dependencies