fix: show warning for non-web targets #3094
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #3094 +/- ## ========================================== + Coverage 95.69% 95.71% +0.01% ========================================== Files 34 34 Lines 1279 1284 +5 Branches 368 370 +2 ========================================== + Hits 1224 1229 +5 Misses 51 51 Partials 4 4
Continue to review full report at Codecov.
|
lib/Server.js Outdated
| if (this.options.liveReload) { | ||
| this.logger.info(`Live reload will not work with a non-web target.`); | ||
| } | ||
| } |
There was a problem hiding this comment.
It is warning, also better keep it inside DevServerPlugin, in future webpack-dev-server will be plugin, so we need put logic inside plugin
snitin315 force-pushed the fix/non-web-target branch from 43fca8f to 790f08f Compare 
rishabh3112 previously approved these changes Mar 28, 2021
| need rebase |
snitin315 force-pushed the fix/non-web-target branch from 353a1af to 71a9eb9 Compare 
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
fixes #2104
Breaking Changes
None
Additional Info
None