fix(test): replace include.toBeTruthy with toContain #2324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For better test output.
nougad requested review from alexander-akait, hiroppy and knagaitsev as code owners 6 tasks
Codecov Report
@@ Coverage Diff @@ ## master #2324 +/- ## ======================================= Coverage 93.92% 93.92% ======================================= Files 34 34 Lines 1284 1284 Branches 366 366 ======================================= Hits 1206 1206 Misses 77 77 Partials 1 1Continue to review full report at Codecov.
|
alexander-akait approved these changes Nov 22, 2019
| Merging and ignore audit problem, let's update package.json in future |
| Thanks for the PR |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For better test output.
Motivation / Use-Case
follow up from #2303