Skip to content

Conversation

odinho
Copy link
Contributor

@odinho odinho commented Nov 8, 2018

This reverts commit 927a2b3.

This is only a test to see whether it fixes Travis.

This reverts commit 927a2b3. This is only a test to see whether it fixes Travis.
@odinho
Copy link
Contributor Author

odinho commented Nov 8, 2018

Mac OS X (stable) still crashed though 🤷‍♂️ :(

@odinho odinho closed this Nov 8, 2018
@odinho odinho deleted the odinho/revert_node_version_checks_test branch November 8, 2018 14:22
@odinho odinho restored the odinho/revert_node_version_checks_test branch November 9, 2018 08:13
@odinho odinho reopened this Nov 9, 2018
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #1564 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1564 +/- ## ======================================= Coverage 74.02% 74.02% ======================================= Files 10 10 Lines 670 670 ======================================= Hits 496 496 Misses 174 174
Impacted Files Coverage Δ
lib/Server.js 81.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55398b5...59aaa79. Read the comment docs.

@alexander-akait
Copy link
Member

Loos CI still failed

@alexander-akait
Copy link
Member

Restart their

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, good job, why it is happens, looks all lines have same checks

@alexander-akait
Copy link
Member

Very very weird error in MacOs, segmentation fault 11 sometimes mean is not enough memory, maybe we can try to increase and test again

@odinho
Copy link
Contributor Author

odinho commented Dec 4, 2018

Closing this.

@odinho odinho closed this Dec 4, 2018
@odinho odinho deleted the odinho/revert_node_version_checks_test branch December 4, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants