Adds an optional peer dependency on webpack-cli

[arcanis]

• This is a bugfix
• This is a metadata update

For Bugs and Features; did you add new tests?

Can publish a package with this PR and see if it actually works but these kind of fixes have been done multiple times to make Yarn 2 happy. Considering webpack-dev-server throws at runtime anyway if webpack-cli is missing this shouldn't bother anyone

Motivation / Use-Case

Yarn 2 currently throws when using webpack-dev-server due to it trying to require webpack-cli without declaring it anywhere in its dependencies:

Error: A package is trying to access another package without the second one being listed as a dependency of the first one Required package: webpack-cli (via "webpack-cli/bin/config-yargs") Required by: webpack-dev-server@virtual:836be30d0802b4899b9a78ca9d744f43f038cccf96d6b8307cbd938d17151f1ac108d2e64290515733c51d0949e0c6d87f9a7c9e245dfe628e5c4ef98f22d752#npm:3.8.0 

Breaking Changes

There is no breaking change for anyone - not even a warning for older package managers. This is a completely safe bugfix that will only impact Yarn users.

Additional Info

Supercedes: #2191

Documentation: https://next.yarnpkg.com/configuration/manifest#peerDependenciesMeta.optional

[codecov]

Codecov Report

Merging #2396 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #2396 +/- ## ======================================= Coverage 93.75% 93.75% ======================================= Files 34 34 Lines 1297 1297 Branches 370 370 ======================================= Hits 1216 1216 Misses 79 79 Partials 2 2

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9937f5...c482546. Read the comment docs.

[arcanis]

Ping @evilebottnawi?

[alexander-akait]

@arcanis npm still not fixed bug about warning optional peer deps?

[arcanis]

They have fixed in November, so if you want to merge the other PR it'll be fine. If you're still a bit wary that's ok, that's why I opened this alternate PR: it only adds the peerDependenciesMeta field (without explicit peerDependency), so it won't affect npm at all. It's a good in-between.

[alexander-akait]

Sounds good!

/cc @hiroppy @Loonride

After merge i will do release

[alexander-akait]

/cc @hiroppy @Loonride

[alexander-akait]

@hiroppy @Loonride feel free to feedback