Skip to content

Conversation

@edave64
Copy link
Contributor

@edave64 edave64 commented Dec 13, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

"Doom" might be applicable to some aspects of the DOM specifications, but I don't think this was intended as some sort of commentary.

I originally spotted the typo on: https://webpack.js.org/loaders/style-loader/

Breaking Changes

N/A

Additional Info

N/A

@jsf-clabot
Copy link

jsf-clabot commented Dec 13, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #432 +/- ## ===================================== Coverage 100% 100% ===================================== Files 3 3 Lines 200 200 Branches 73 73 ===================================== Hits 200 200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6164d5...36f8f53. Read the comment docs.

@alexander-akait
Copy link
Member

Please accept CLA

@edave64
Copy link
Contributor Author

edave64 commented Dec 13, 2019

@alexander-akait
Copy link
Member

Can you regenerate lock file? Just remove package-lock.json and run npm i to avoid npm audit problems

@edave64
Copy link
Contributor Author

edave64 commented Dec 13, 2019

@evilebottnawi That seems to have fixed the audit.

@alexander-akait alexander-akait merged commit 4c1e3f3 into webpack:master Dec 13, 2019
@alexander-akait
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants