Skip to content

Conversation

@jhnns
Copy link
Member

@jhnns jhnns commented Mar 14, 2014

The current sass-loader generates module.exports = '..css..'. This makes using the css-loader impossible because it will try to parse it as CSS.

According to @Sorka's guidelines a loader should do only one thing. I've adjusted the sass-loader to only transform the sass string to a css string. If you like to just retrieve a css string, you now need to use it in conjunction with the raw-loader:

var css = require("raw!sass!./file.scss");

I've also updated the README accordingly. The sass-loader now works exactly like the less-loader.

This is a breaking change and should receive at least a minor version bump (we're still in development, so it's ok not do a major version bump).

jtangelder added a commit that referenced this pull request Mar 15, 2014
Return pure CSS instead of JavaScript
@jtangelder jtangelder merged commit 6c9ccd5 into webpack:master Mar 15, 2014
@jtangelder
Copy link
Contributor

alright, i still have to fix #2, then i will release the next version.

@jhnns
Copy link
Member Author

jhnns commented Mar 16, 2014

Ok thx 👍

@jhnns jhnns deleted the return-pure-css branch March 16, 2014 18:48
@jtangelder
Copy link
Contributor

Release it anyway, #2 might take a while...
it will be released under 0.1.0, since it's a breaking change.

@jhnns
Copy link
Member Author

jhnns commented Apr 22, 2014

Cool, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants