Return pure CSS instead of JavaScript #3
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current sass-loader generates
module.exports = '..css..'. This makes using the css-loader impossible because it will try to parse it as CSS.According to @Sorka's guidelines a loader should do only one thing. I've adjusted the sass-loader to only transform the sass string to a css string. If you like to just retrieve a css string, you now need to use it in conjunction with the raw-loader:
I've also updated the README accordingly. The sass-loader now works exactly like the less-loader.
This is a breaking change and should receive at least a minor version bump (we're still in development, so it's ok not do a major version bump).