Skip to content

Conversation

@RAX7
Copy link
Contributor

@RAX7 RAX7 commented Oct 31, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR, can you provide changes in perf?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check perf after changes (any tool for this) and I am fine with merging this

@RAX7
Copy link
Contributor Author

RAX7 commented Nov 1, 2022

alexander-akait
alexander-akait previously approved these changes Nov 7, 2022
@alexander-akait
Copy link
Member

@RAX7 Looks like some tests failed, can you check it?

@RAX7
Copy link
Contributor Author

RAX7 commented Nov 7, 2022

@alexander-akait hope this works now 😄

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 92.20% // Head: 91.55% // Decreases project coverage by -0.64% ⚠️

Coverage data is based on head (17fcb66) compared to base (22d3ce7).
Patch coverage: 84.09% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@ ## master #470 +/- ## ========================================== - Coverage 92.20% 91.55% -0.65%  ========================================== Files 7 7 Lines 590 604 +14 Branches 190 198 +8 ========================================== + Hits 544 553 +9  - Misses 37 42 +5  Partials 9 9 
Impacted Files Coverage Δ
src/utils.js 89.32% <84.09%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit dcf1635 into webpack:master Nov 7, 2022
@alexander-akait
Copy link
Member

Thank you

@RAX7 RAX7 deleted the perf-and-refactor branch November 8, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants