Skip to content

refactor: handle the uppercase srcset attribute #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020
Merged

refactor: handle the uppercase srcset attribute #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/attribute-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ function processMatch(match, strUntilValue, name, value, index) {
return;
}

if (name === 'srcset') {
if (name.toLowerCase() === 'srcset') {
let sourceSet;

try {
Expand Down
442 changes: 266 additions & 176 deletions test/__snapshots__/attributes-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

204 changes: 120 additions & 84 deletions test/__snapshots__/esModule-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

68 changes: 40 additions & 28 deletions test/__snapshots__/loader.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

405 changes: 234 additions & 171 deletions test/__snapshots__/minimize-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

136 changes: 80 additions & 56 deletions test/__snapshots__/root-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions test/fixtures/simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ <h2>An Ordered HTML List</h2>
<img srcset="," src="image.png" alt="Elva dressed as a fairy">
<img srcset=",,," src="image.png" alt="Elva dressed as a fairy">
<img srcset="image.png 480w, image.png 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<IMG srcset="image.png 480w, image.png 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<img SRCSET="image.png 480w, image.png 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<IMG SRCSET="image.png 480w, image.png 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<img srcset="image.png?foo=bar,baz 480w, image.png?bar=baz,foo 800w" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<img srcset="image.png?foo=bar,baz 480h, image.png?bar=baz,foo 800h" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
<img srcset="image.png?foo=bar,baz, image.png?bar=baz,foo" sizes="(max-width: 600px) 480px, 800px" src="image.png" alt="Elva dressed as a fairy">
Expand Down