Skip to content

Conversation

@alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The data attribute should be handled too

Breaking Changes

BREAKING CHANGE: the data attribute of object tag now handled

Additional Info

No

BREAKING CHANGE: the `data` attribute of `object` tag now handled
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #227 +/- ## ======================================= Coverage 93.11% 93.11% ======================================= Files 4 4 Lines 247 247 Branches 70 70 ======================================= Hits 230 230 Misses 15 15 Partials 2 2
Impacted Files Coverage Δ
src/utils.js 90.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331f45a...53e410d. Read the comment docs.

@alexander-akait alexander-akait merged commit a3a92f1 into master Jan 22, 2020
@alexander-akait alexander-akait deleted the feat-handle-the-data-attribute-of-object-tag branch January 22, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants