docs(README): add more context to localIdentName #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky suggested changes May 5, 2018
README.md Outdated
| | ||
| ### `localIdentName` | ||
| | ||
| You can configure the generated ident with the `localIdentName` query parameter (default `[hash:base64]`). See [loader-utils's documentation](https://github.com/webpack/loader-utils#interpolatename) for more information on options. |
There was a problem hiding this comment.
- (default `[hash:base64]`)Already in the options table :)
README.md Outdated
| } | ||
| ``` | ||
| | ||
| > :information_source: For prerendering with extract-text-webpack-plugin you should use `css-loader/locals` instead of `style-loader!css-loader` **in the prerendering bundle**. It doesn't embed CSS but only exports the identifier mappings. |
There was a problem hiding this comment.
:information_source: => ℹ️ ('rendered')
michael-ciniawsky changed the title localIdentName 
Codecov Report
@@ Coverage Diff @@ ## master #711 +/- ## ======================================= Coverage 98.43% 98.43% ======================================= Files 11 11 Lines 384 384 Branches 90 90 ======================================= Hits 378 378 Misses 6 6Continue to review full report at Codecov.
|
| @michael-ciniawsky I cleaned up the two things you mentioned. |
michael-ciniawsky approved these changes May 5, 2018
michael-ciniawsky added status: Approved and removed pr_action: Review severity: 4 (inconvenient) status: Pending labels Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updates README file so the
localIdentNameoptions are clearer and easier to access, added a link to it in the options, and moved it to its own section.Did you add tests for your changes?
No, not relevant
If relevant, did you update the README?
Yes
Summary
It's currently not clear from the README what all the relevant options are for
localIdentNameand it should have a link in the options table as to make access to it easier.Does this PR introduce a breaking change?
No
Other information